Skip to content

Don't close candidate on eperm #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 8, 2025
Merged

Don't close candidate on eperm #85

merged 8 commits into from
Jul 8, 2025

Conversation

Karolk99
Copy link
Contributor

@Karolk99 Karolk99 commented Jun 27, 2025

Closes #82 and also fixes the race condition described in PR 84

@Karolk99 Karolk99 requested a review from mickel8 June 27, 2025 16:07
@Karolk99
Copy link
Contributor Author

The problem with tests seems to be caused by ICEAgent trying to always send a binding request on the same pair, even though it always gets eperm response from the socket.

@Karolk99 Karolk99 force-pushed the 82/dont-close-on-eperm branch from 6a072cf to 3a81786 Compare June 30, 2025 10:23
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.81%. Comparing base (7552d06) to head (1324219).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   83.88%   85.81%   +1.92%     
==========================================
  Files          25       25              
  Lines        1837     1868      +31     
==========================================
+ Hits         1541     1603      +62     
+ Misses        296      265      -31     
Files with missing lines Coverage Δ
lib/ex_ice/priv/checklist.ex 100.00% <100.00%> (ø)
lib/ex_ice/priv/ice_agent.ex 87.64% <100.00%> (+1.55%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4854d81...1324219. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Karolk99 Karolk99 requested a review from mickel8 June 30, 2025 15:46
@Karolk99
Copy link
Contributor Author

Karolk99 commented Jul 7, 2025

Sending a connectivity check or nominating a pair can now affect state (for example, on socket error), so we have to handle connection state updates after all binding requests.

@Karolk99 Karolk99 merged commit b1100cd into master Jul 8, 2025
4 checks passed
Karolk99 added a commit that referenced this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eperm results in closing local candidate
2 participants