-
Notifications
You must be signed in to change notification settings - Fork 4
Don't close candidate on eperm #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The problem with tests seems to be caused by ICEAgent trying to always send a binding request on the same pair, even though it always gets eperm response from the socket. |
6a072cf
to
3a81786
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 83.88% 85.81% +1.92%
==========================================
Files 25 25
Lines 1837 1868 +31
==========================================
+ Hits 1541 1603 +62
+ Misses 296 265 -31
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sending a connectivity check or nominating a pair can now affect state (for example, on socket error), so we have to handle connection state updates after all binding requests. |
Closes #82 and also fixes the race condition described in PR 84